Skip to content

Jira ServiceDesk: Fix create attachment #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Jira ServiceDesk: Fix create attachment #1121

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6d4beb
Jira ServiceDesk: Fix create attachment
Feb 15, 2023
4723a3c
Corrected formatting with black of service_desk.py
Feb 16, 2023
c4fe53f
undid wrong black formatting
Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions atlassian/service_desk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,11 +523,19 @@ def attach_temporary_file(self, service_desk_id, filename):
experimental_headers["X-Atlassian-Token"] = "no-check"

with open(filename, "rb") as file:
result = (
self.post(path=url, headers=experimental_headers, files={"file": file})
.json()
.get("temporaryAttachments")
)
# bug https://github.com/atlassian-api/atlassian-python-api/issues/1056
# in advanced_mode it returns the raw response therefore .json() is needed
# in normal mode this is not needed and would fail
if self.advanced_mode:
result = (
self.post(path=url, headers=experimental_headers, files={"file": file})
.json()
.get("temporaryAttachments")
)
else:
result = self.post(path=url, headers=experimental_headers, files={"file": file}).get(
"temporaryAttachments"
)
temp_attachment_id = result[0].get("temporaryAttachmentId")

return temp_attachment_id
Expand Down