Skip to content

Fix failed doc test and enable doc test on CI #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 13, 2019
Merged

Fix failed doc test and enable doc test on CI #597

merged 5 commits into from
Dec 13, 2019
+12 −4

Conversation

k-nasa
Copy link
Member

@k-nasa k-nasa commented Nov 28, 2019

I fix doc test, because some documentation test is failed.

@k-nasa k-nasa added the documentation Improvements or additions to documentation label Nov 28, 2019
@k-nasa k-nasa changed the title Fix failed doc test Fix failed doc test and enable doc test on CI Nov 28, 2019
k-nasa
k-nasa commented Nov 28, 2019
View reviewed changes
@k-nasa k-nasa requested review from a user and yoshuawuyts November 29, 2019 01:54
@k-nasa
Copy link
Member Author

k-nasa commented Dec 7, 2019

May I merge this?
@yoshuawuyts @stjepang

yoshuawuyts
yoshuawuyts approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks heaps!

Sorry, I was on vacation. Thanks so much for this patch!

@yoshuawuyts yoshuawuyts merged commit 83a488b into async-rs:master Dec 13, 2019
@k-nasa k-nasa deleted the fix_doc_test branch December 14, 2019 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@k-nasa @yoshuawuyts