Make sure into_raw_fd doesn't close the file descriptor #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously all of the into_raw_fd implementations only returns a copy of the inner RawFd, while still holding the ownership of the file descriptor when returning for into_raw_fd. Since `self` is dropped at the end of into_raw_fd, the returned file descriptor will actually be closed, render the function unuseable. The patch makes sure that into_raw_fd actually takes the ownership of the file descriptor all the way from the inner IoHandle. To achieve this, I have to use an Option in IoHandle to store the I/O source. It's not pretty, but I cannot come up with a better way.
ghost
approved these changes
Sep 8, 2019
ghost
mentioned this pull request
Co-Authored-By: Stjepan Glavina <[email protected]>
|
@stjepang Thanks. Applied |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 8, 2019
148: Make sure into_raw_fd doesn't close the file descriptor r=stjepang a=yshui Closes #147 Co-authored-by: Yuxuan Shui <[email protected]> Co-authored-by: yshui <[email protected]>
Build succeeded
|
bors bot
added a commit
that referenced
this pull request
Sep 8, 2019
165: Fix a bug in conversion of File into raw handle r=stjepang a=stjepang Same bugfix as #148, but applied to `async_std::fs::File`. Co-authored-by: Stjepan Glavina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #147