Remove all special-casing for local version identifiers #8818
+3
−396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/local
branch
4 times, most recently
from
34a20a8 to
eec586a
Compare
charliermarsh
added
the
internal
charliermarsh
force-pushed
the
charlie/local
branch
from
eec586a to
5162977
Compare
charliermarsh
force-pushed
the
charlie/local
branch
3 times, most recently
from
ebb096e to
cb920e4
Compare
charliermarsh
force-pushed
the
charlie/local
branch
from
cb920e4 to
37e32e2
Compare
charliermarsh
added a commit
that referenced
this pull request
Nov 6, 2024
## Summary After #8797, we have spec-compliant handling for local version identifiers and can completely remove all the special-casing around it.
Merged
zanieb
pushed a commit
that referenced
this pull request
Nov 7, 2024
After #8797, we have spec-compliant handling for local version identifiers and can completely remove all the special-casing around it.
zanieb
pushed a commit
that referenced
this pull request
Nov 7, 2024
After #8797, we have spec-compliant handling for local version identifiers and can completely remove all the special-casing around it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After #8797, we have spec-compliant handling for local version identifiers and can completely remove all the special-casing around it.