[red-knot] Increase durability of read-only File fields
#17757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
MichaReiser
changed the title
MichaReiser
changed the title
File fields
carljm
approved these changes
May 1, 2025
| .status(FileStatus::Exists) | ||
| .revision(FileRevision::zero()) | ||
| .permissions(None) | ||
| .permissions_durability(Durability::HIGH) |
Contributor
There was a problem hiding this comment.
What happens if permissions on a file do change? Do we treat them as immutable and ignore such changes? Do we not even watch for permission changes? I assume permissions aren't part of the file identity...
Member
Author
There was a problem hiding this comment.
Virtual files don't have a permission, it's always set to None
dcreager
added a commit
that referenced
this pull request
May 1, 2025
* main: Improve messages outputted by py-fuzzer (#17764) [`red-knot`] Allow subclasses of Any to be assignable to Callable types (#17717) [red-knot] Increase durability of read-only `File` fields (#17757) [red-knot] Cache source type during semanic index building (#17756) [`flake8-use-pathlib`] Fix `PTH116` false positive when `stat` is passed a file descriptor (#17709) Sync vendored typeshed stubs (#17753)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increase the durability of read-only fields on
FiletoHIGHTest Plan
cargo test