Skip to content

Conversation

@sharkdp
Copy link
Contributor

@sharkdp sharkdp commented Feb 3, 2025

Summary

WIP.

Adds some preliminary tests for typing.Final.

Test Plan

New MD tests

@sharkdp sharkdp added the ty Multi-file analysis & type inference label Feb 3, 2025
@MichaReiser
Copy link
Member

Should we just merge those?

@sharkdp sharkdp force-pushed the david/add-support-for-final branch from 8f1c56e to c320b92 Compare March 14, 2025 11:23
@sharkdp sharkdp marked this pull request as ready for review March 14, 2025 11:23
@sharkdp
Copy link
Contributor Author

sharkdp commented Mar 14, 2025

Should we just merge those?

I think there's no harm in doing so (e.g. having to change them frequently while working on something else). Rebased.

@github-actions
Copy link
Contributor

mypy_primer results

No ecosystem changes detected ✅

@sharkdp sharkdp merged commit a22d206 into main Mar 14, 2025
22 checks passed
@sharkdp sharkdp deleted the david/add-support-for-final branch March 14, 2025 11:30
dcreager added a commit that referenced this pull request Mar 14, 2025
* main:
  [red-knot] Use `try_call_dunder` for augmented assignment (#16717)
  [red-knot] Document current state of attribute assignment diagnostics (#16746)
  [red-knot] Case sensitive module resolver (#16521)
  [red-knot] Very minor simplification of the render tests (#16759)
  [syntax-errors] Unparenthesized assignment expressions in sets and indexes (#16404)
  ruff_db: add a new diagnostic renderer
  ruff_db: add `context` configuration
  red_knot: plumb through `DiagnosticFormat` to the CLI
  ruff_db: add concise diagnostic mode
  [syntax-errors] Star annotations before Python 3.11 (#16545)
  [syntax-errors] Star expression in index before Python 3.11 (#16544)
  Ruff 0.11.0 (#16723)
  [red-knot] Preliminary tests for typing.Final (#15917)
  [red-knot] fix: improve type inference for binary ops on tuples (#16725)
  [red-knot] Assignments to attributes (#16705)
  [`pygrep-hooks`]: Detect file-level suppressions comments without rul… (#16720)
  Fallback to requires-python in certain cases when target-version is not found (#16721)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants