Upgrade to LLVM 20.1.0 #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, the new toolchain release is marked as a pre-release for the moment since I haven't tested them. (This PR can be the test!) I also noticed the archives are significantly larger. I'd like to investigate that before removing the pre-release flag. Maybe tomorrow... |
indygreg
force-pushed
the
indygreg/llvm-20
branch
from
20fa2c2 to
2807e8b
Compare
I just published an LLVM 20.1.0 toolchain with some computed gotos patches to hopefully improve performance of CPython. https://github.com/indygreg/toolchain-tools/releases/tag/toolchain-bootstrap%2F20250308 One of the patches changes codegen to fix a regression in LLVM 19. The other enables bolt to work with computed gotos. To take full advantage of this functionality we patch CPython configure to remove some `--skip-funcs` which are no longer required.
indygreg
force-pushed
the
indygreg/llvm-20
branch
from
2807e8b to
961adf8
Compare
zanieb
approved these changes
Mar 9, 2025
|
I did a quick audit of the LLVM distribution bloat. Looks mostly organic. I removed the pre-release label from the release. I'm comfortable landing this if you are. |
|
Great thanks for following up. |
|
Thanks for merging this regression-fix swiftly! 👍🏻 Is the branch indygreg/no-plt unnecessary? |
|
Changes to PLT and symbol binding need to be considered separately and deliberately. I published the branch so others can conduct performance analysis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just published an LLVM 20.1.0 toolchain with some computed gotos patches to hopefully improve performance of CPython.
https://github.com/indygreg/toolchain-tools/releases/tag/toolchain-bootstrap%2F20250308
One of the patches changes codegen to fix a regression in LLVM 19.
The other enables bolt to work with computed gotos. To take full advantage of this functionality we patch CPython configure to remove some
--skip-funcswhich are no longer required.