Skip to content

Conversation

@martincostello
Copy link
Member

@martincostello martincostello commented Jun 27, 2020

This PR adds support for ASP.NET 5, starting with preview 6 through to RC1.

@martincostello martincostello added this to the 5.0.0 milestone Jun 27, 2020
martincostello added a commit to martincostello/AspNet.Security.OAuth.Providers that referenced this pull request Jun 28, 2020
Move the parameters into a local variable before passing to the FormUrlEncodedContent constructor so that it's easier to make nullable annotations happier in .NET 5 (see aspnet-contrib#438).
martincostello added a commit that referenced this pull request Jun 28, 2020
Move the parameters into a local variable before passing to the FormUrlEncodedContent constructor so that it's easier to make nullable annotations happier in .NET 5 (see #438).
@martincostello martincostello force-pushed the AspNet-5 branch 4 times, most recently from 31b82d5 to 30057c9 Compare July 3, 2020 18:33
@martincostello martincostello force-pushed the AspNet-5 branch 2 times, most recently from 380246a to 9773507 Compare July 21, 2020 19:43
@martincostello
Copy link
Member Author

Once RC1 lands (after preview 8), I'll look at merging this to a rel/5.0.0 (or similar) so that we start publishing 5.0 packages to MyGet.

@martincostello
Copy link
Member Author

martincostello commented Aug 11, 2020

For RC1 we can use the new "one-shot" hash methods (dotnet/aspnetcore#24696) in these two providers:

We can also leverage the new Convert.ToHexString() method here:

private static string GetHash(HashAlgorithm algorithm, string input)
{
var builder = new StringBuilder();
foreach (byte b in algorithm.ComputeHash(Encoding.UTF8.GetBytes(input)))
{
builder.Append(b.ToString("x2", CultureInfo.InvariantCulture));
}
return builder.ToString();
}

@martincostello
Copy link
Member Author

I think something in Arcade needs updating somewhere, as now the build gets this error with preview 8:

/home/runner/work/AspNet.Security.OAuth.Providers/AspNet.Security.OAuth.Providers/.dotnet/sdk/5.0.100-preview.8.20417.9/NuGet.targets(128,5): error : Invalid restore input. Invalid target framework 'unsupported'. Input files: /home/runner/work/AspNet.Security.OAuth.Providers/AspNet.Security.OAuth.Providers/.packages/microsoft.dotnet.arcade.sdk/5.0.0-beta.20180.5/tools/Tools.proj. [/home/runner/work/AspNet.Security.OAuth.Providers/AspNet.Security.OAuth.Providers/.packages/microsoft.dotnet.arcade.sdk/5.0.0-beta.20180.5/tools/Tools.proj]

Vanilla dotnet build and Visual Studio builds are fine.

Updates to support ASP.NET 5, using preview 6.
Remove obsolete members.
Update to preview 5 of ASP.NET 5.
Update to preview 8 of ASP.NET 5.
Update the version metadata to align with ASP.NET Core, so we generate prerelease labels like "preview.8." or "rc.1.".
@martincostello martincostello changed the base branch from dev to rel/5.0.0 September 5, 2020 14:51
Update to RC1 of ASP.NET 5.
Use new HashData() methods for SHA256 and MD5.
Use Convert.ToHexString().
@martincostello martincostello changed the title [WIP] Support ASP.NET 5 Support ASP.NET 5 using RC1 Sep 14, 2020
@martincostello martincostello marked this pull request as ready for review September 14, 2020 20:52
@martincostello martincostello merged commit 707c62c into aspnet-contrib:rel/5.0.0 Sep 14, 2020
@martincostello martincostello deleted the AspNet-5 branch September 14, 2020 20:53
@martincostello
Copy link
Member Author

See #472.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant