-
-
Notifications
You must be signed in to change notification settings - Fork 128
Generate stable test output #31
Conversation
|
Additional fixes to avoid depending on version numbers for the expected output:
-<div class="content"><!-- Generator: GNU source-highlight 3.1.7
+<div class="content"><!-- Generator: GNU source-highlight
-<meta name="generator" content="AsciiDoc 8.6.9">
+<meta name="generator" content="AsciiDoc test-0.1.1"> |
tests/testasciidoc.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be named _frozen_localtime instead of _fake_localtime to be consistent.
|
+1 What about your comments? Are you still working on this PR or should we merge it? Cheers, |
|
I think I will apply the 2 suggestions I've proposed in comments : re-reading them after some days, I am +1 with myself 😄 Then this PR is ready for merging, and I could work to finish #30. |
|
Hi, For the Last updated field, you could also use the footer-style attribute to none as default in the tests. This would remove the last updated field in the html pages for the tests. Joseph |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does adding the generated version help to produce stable output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually the switch --gen-version toggle off the version number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, makes sense (well your change does, the option doesn't, should be --no-gen-version).
|
Are you able to squash the commits correcting previous commits? Leaving 4 commits. |
|
ok, I'll try to rewrite the history |
|
I've rebased and merged the commits. |
Generate stable test output
Currently the output of the tests is not stable when running in different environments:
Last updatedtimestamp is printed in the output of many testsThis PR removes the above glitches. It is a prerequisite for fixing issue #30
Details of the changes:
time.localtimefunction and theTZenvironment variable which are used to generate theLast updatedtimestampbarchart.pyfile to avoid printing an error message with the absolute path of the missing file{docfile}with relative path{docname}.txt