delete manually disabled self-destruct tasks #181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjusts an example to disable a single task before it runs out of iterations. the task disables itself. without the fix in TaskScheduler.h, one can observe a memory leak, as the task which disabled itself is not deleted. the TaskScheduler is adjusted to check the self-destruct request flag of disabled tasks and to delete such tasks.
Author
|
notice that the example which is modified in this PR needs #180 to compile. |
Owner
|
Pushed into testing branch as v3.8.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjusts an example to disable a single task before it runs out of iterations. the task disables itself. without the fix in
TaskScheduler.h, one can observe a memory leak, as the task which disabled itself is not deleted.the TaskScheduler is adjusted to check the self-destruct request flag of disabled tasks and to delete such tasks.
output of original example
output of modified example without fix:
output of modified example with fix: