Skip to content

Add various deprecation warnings #16174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
+959 −61
Open

Add various deprecation warnings #16174

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0bb5fb9
Natspect memory-safe annotation deprecation warning
matheusaaguiar Aug 18, 2025
32386da
Update natspec warning tests
matheusaaguiar Aug 18, 2025
6902afa
ABI coder v1 deprecation warning
matheusaaguiar Aug 19, 2025
1c103d2
Update abi coder v1 tests
matheusaaguiar Aug 19, 2025
254c582
Contract type comparison deprecation warning
matheusaaguiar Aug 19, 2025
20f25e5
Update contract type deprecation warning tests
matheusaaguiar Aug 19, 2025
900a7d3
Virtual modifier deprecation warning
matheusaaguiar Aug 19, 2025
d1e15dc
Update virtual modifier warning tests
matheusaaguiar Aug 19, 2025
43a7c3d
Deprecation warning for send and transfer member functions
matheusaaguiar Aug 19, 2025
11ac957
Update send/transfer warning tests
matheusaaguiar Aug 19, 2025
bcdb513
zeppelin ext test workaround
matheusaaguiar Aug 22, 2025
16461d0
Update docs
matheusaaguiar Sep 2, 2025
069863a
Changelog
matheusaaguiar Oct 31, 2025
fbc6644
fixup! Natspect memory-safe annotation deprecation warning
matheusaaguiar Nov 3, 2025
375de69
fixup! Update natspec warning tests
matheusaaguiar Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libsolidity/analysis/DocStringTagParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ bool DocStringTagParser::visit(InlineAssembly const& _assembly)
m_errorReporter.warning(
2424_error,
_assembly.location(),
"Natspec memory safe annotation for inline assembly is deprecated and scheduled for removal in the next breaking version (0.9)."
"Natspec 'memory-safe-assembly' special comment for inline assembly is deprecated and scheduled for removal in the next breaking version (0.9)."
Copy link
Collaborator Author

@matheusaaguiar matheusaaguiar Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clonker I've reworded the warning message here to be more in line with the suggestion you made for the changelog entry....what do you think?

Copy link
Member

@clonker clonker Nov 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thinking about it again, it would be even better to mention that the assembly block annotation should be used instead. Like "Use the 'memory-safe' assembly block annotation instead". Or go with the whole sentence as in the docs.

);
}
else
Expand Down