test(e2e): add e2e test for interaction with ArgoCD API #549
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
+ Coverage 44.16% 44.21% +0.05%
==========================================
Files 89 89
Lines 11925 11925
==========================================
+ Hits 5267 5273 +6
+ Misses 6223 6216 -7
- Partials 435 436 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| reqURL := c.url() | ||
| reqURL.Path = fmt.Sprintf("/api/v1/applications/%s", name) | ||
|
|
||
| req, err := http.NewRequest(http.MethodDelete, reqURL.String(), nil) |
There was a problem hiding this comment.
I think you need to set proper content-type for this request
There was a problem hiding this comment.
I added code to set the Content-Type header to application/json in a new commit
.github/workflows/ci.yaml
Outdated
| - name: Install ArgoCD CRDs | ||
| run: kubectl apply -f https://raw.githubusercontent.com/argoproj/argo-cd/stable/manifests/crds.yaml |
There was a problem hiding this comment.
This is actually part of setting up the test environment later.
There was a problem hiding this comment.
Thanks for the feedback! You were right, that part was related to the test environment setup.
Based on your comment, I've reverted the changes to ci.yaml.
I've modified the test setup logic instead of changing the CI configuration. The test suite now checks for the existence of the required contexts at startup. If a context is not found (as is common in a local environment), the test is now skipped with an informative message instead of failing.
This change has no impact on the CI environment, where the contexts are present and the tests will run as they always have. It simply makes the test suite more robust and convenient for local development.
juanxiu
force-pushed
the
issue/#413
branch
2 times, most recently
from
1de9807 to
8536769
Compare
| break | ||
| } | ||
| } | ||
| asserts.True(found, "application %s not found in list", appName) |
test/e2e/application_test.go
Outdated
| // 5. Verify Deletion | ||
| _, err = s.argoClient.GetApplication(appName) | ||
| asserts.Error(err) | ||
| asserts.Contains(err.Error(), "not found") |
There was a problem hiding this comment.
I think this step is unnecessary.
|
@jannfis The test case failure was caused by a nil issue. Since the test turned out to be unnecessary, I have removed it. Could you please approve the actions? |
- set content type for delete request header - add create, list, get, delete api test Signed-off-by: yeonsoo <[email protected]>
jannfis
changed the title
4 participants
What does this PR do / why we need it:
This PR introduces a new end-to-end test case to validate the lifecycle of an Application resource by interacting directly with the Argo CD API.
Our existing end-to-end tests create Application resources declaratively, by applying manifests directly to the cluster. This approach has a gap: it doesn't fully simulate user actions performed through the Argo CD API. This can lead to subtle bugs in the API interaction path going undetected.
To improve test coverage and prevent similar issues, this change adds a test that specifically covers the API-driven creation, retrieval, and deletion of applications, ensuring our integration with the Argo CD API is robust.
Which issue(s) this PR fixes:
Fixes #413
How to test changes / Special notes to the reviewer:
CreateApplicationGetApplicationandListApplicationsDeleteApplicationThe client now correctly encapsulates the logic for authentication and request signing, making it a reliable tool for our E2E test suite.
This new test provides greater confidence that creating and managing applications via the Argo CD API works as expected in an environment where the agent is active.
Checklist