Skip to content

Fix: only transmit CAN frame on valid opcode AND always send a status message upon attempted CAN transmit #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2023
Merged

Fix: only transmit CAN frame on valid opcode AND always send a status message upon attempted CAN transmit #5

merged 3 commits into from
Sep 22, 2023

Conversation

@aentinger
Copy link
Contributor

@aentinger aentinger commented Sep 22, 2023

No description provided.

@aentinger aentinger self-assigned this Sep 22, 2023
@facchinm
Copy link
Member

facchinm commented Sep 22, 2023

After applying this patch I always get write: No buffer space available on Linux side after calling something like ./cansend can1 300#AC.AB.AD.AE.75.49.1A . Is there maybe another patch to be applied on the other side?

@aentinger
Copy link
Contributor Author

aentinger commented Sep 22, 2023

I even get this message without the patch. That's why I say that CAN is broken ...

@facchinm
Copy link
Member

facchinm commented Sep 22, 2023

With this patch only 8c6e6e2 and arduino/meta-partner-arduino@dabb311 on the linux side I was able to send any amount of packets 🙃

@aentinger
Copy link
Contributor Author

aentinger commented Sep 22, 2023

I'll be merging this, because this patch is essentially bug-free, the problem is somewhere where in the can driver handling.

Also this firmware will not be pulled into the X8 image, as long as https://github.com/arduino/meta-partner-arduino/blob/main/recipes-kernel/linux-firmware/linux-firmware-arduino-portenta-x8-stm32h7_git.bb#L19 is not updated.

@aentinger aentinger merged commit 67b90a1 into master Sep 22, 2023
@aentinger aentinger deleted the fix-can-tx branch September 22, 2023 08:39
facchinm added a commit that referenced this pull request Nov 6, 2024
@facchinm
rpc: WORKAROUND: disable metal_mutex
02b3427 
Enabling them crashes the m7 fw with this stacktrace

 #0  HardFault_Handler () at src/stm32h7xx_it.c:47
 #1  <signal handler called>
 #2  0x08004770 in __metal_mutex_acquire (mutex=0x24003318 <rvdev+88>)
    at libraries/openamp_arduino/src/metal/system/generic/mutex.h:60
 #3  metal_mutex_acquire (mutex=0x24003318 <rvdev+88>)
    at libraries/openamp_arduino/src/metal/mutex.h:59
 #4  rpmsg_virtio_rx_callback (vq=0x240070d0)
    at libraries/openamp_arduino/src/rpmsg_virtio.c:548
 #5  0x080041da in rproc_virtio_notified (vdev=0x24007058,
    notifyid=notifyid@entry=0)
    at libraries/openamp_arduino/src/remoteproc_virtio.c:341
 #6  0x08003b48 in MAILBOX_Poll (vdev=<optimized out>)
    at libraries/openamp_arduino/src/mailbox_hsem_if.c:122
 #7  0x08003d1e in OPENAMP_check_for_message ()
    at libraries/openamp_arduino/src/openamp.c:166
 #8  0x080013e2 in HSEM1_IRQHandler () at src/rpc.c:116
 #9  <signal handler called>
 #10 0x080013a8 in serial_rpc_ready () at src/rpc.c:97
 #11 0x08003596 in try_execute_m4_app () at src/m4_util.c:74
 #12 0x0800088a in main () at src/main.c:124

Investigate a proper fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facchinm facchinm facchinm approved these changes

@MaxPayne86 MaxPayne86 Awaiting requested review from MaxPayne86

Assignees

@aentinger aentinger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aentinger @facchinm