Kill now kills all the childrens in the process-tree on MacOS and Windows.
#34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
changed the title
Kill method.Kill now kill the whole process-tree on MacOS and Windows.
lucarin91
reviewed
Apr 30, 2025
There was a problem hiding this comment.
I would also update this comment. it seems that now the same trick is also used for mac https://github.com/arduino/go-paths-helper/blob/a79cedacd25545f13f128af1e5b077a205d8fc61/process.go#L59C2-L59C37
alessio-perugini
approved these changes
Apr 30, 2025
cmaglie
force-pushed
the
kill_process_darwin
branch
from
a79ceda to
0ee00d8
Compare
cmaglie
force-pushed
the
kill_process_darwin
branch
from
0ee00d8 to
4391f08
Compare
cmaglie
added
type: enhancement
alessio-perugini
approved these changes
Apr 30, 2025
cmaglie
changed the title
Kill now kill the whole process-tree on MacOS and Windows.Kill now kills all the childrens in the process-tree on MacOS and Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Killmethod now kills the process group on MacOS (in a similar way we did for Linux) and Windows.The Windows parts are a bit convoluted but seem to work nicely.