Skip to content

Conversation

msujew
Copy link
Contributor

@msujew msujew commented Apr 4, 2022

Motivation

Closes #552

Change description

Removes all contributed commands which programmatically enable users to split editors. Also disables widget dragging so that it's not possible to split editors that way. I believe the dragging functionality hasn't been used anyway?

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@fstasi fstasi requested review from fstasi, per1234 and ubidefeo April 4, 2022 14:48
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fstasi
Copy link
Contributor

fstasi commented Apr 5, 2022

@ubidefeo can you please check if this also fixes
#793
#656
#909

if split is now disabled we can probably close #909

@ubidefeo
Copy link

ubidefeo commented Apr 5, 2022

@msujew @AlbyIanna @fstasi
widget dragging is still possible in the sidebar and allows rearranging of icons

CleanShot 2022-04-05 at 11 49 08@2x

@AlbyIanna
Copy link
Contributor

@ubidefeo do we have a separate issue for that? Let's keep the focus of this PR to "prevent editor tabs from splitting". The reason why @msujew also disabled widget dragging, as far as I understood, was to prevent users from moving the sidebar widgets inside the editor and do stuff like this:
image

@ubidefeo
Copy link

ubidefeo commented Apr 5, 2022

LGTM

Ignore the following in favour of another separate issue

@msujew @AlbyIanna @fstasi
widget dragging is still possible in the sidebar and allows rearranging of icons

@AlbyIanna AlbyIanna merged commit c430cf0 into main Apr 5, 2022
@AlbyIanna AlbyIanna deleted the msujew/disable-dragging branch April 5, 2022 10:21
@per1234
Copy link
Contributor

per1234 commented Apr 6, 2022

please check if this also fixes
#793

It does not. I am still able to reproduce #793 using 2.0.0-rc5-snapshot-c430cf0

#656

It does not. I am still able to reproduce #656 using 2.0.0-rc5-snapshot-c430cf0

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Apr 8, 2022
@kittaakos
Copy link
Contributor

I am getting an error every time I click anywhere in the IDE. The error is thrown in the customized code. this is not bound (undefined):

gh_940.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to close split tabs
6 participants