Skip to content

Reduced visual clutter in Library Manager List #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Reduced visual clutter in Library Manager List #1611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions arduino-ide-extension/src/browser/style/list-widget.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,12 @@

.filterable-list-container .items-container > div > div:nth-child(even) {
background-color: var(--theia-sideBar-background);
filter: contrast(95%);
filter: contrast(85%);
}

.filterable-list-container .items-container > div > div:hover {
background-color: var(--theia-sideBar-background);
filter: contrast(90%);
filter: contrast(95%);
}

.component-list-item {
Expand All @@ -78,6 +78,7 @@
display: flex;
justify-content: space-between;
align-items: center;
margin-top: 2px;
}

.component-list-item .header .name {
Expand All @@ -94,6 +95,7 @@
}

.component-list-item .header .version {
font-weight: bold;
color: var(--theia-panelTitle-inactiveForeground);
}

Expand Down Expand Up @@ -127,10 +129,27 @@
flex-direction: row-reverse;
}

.component-list-item .summary {
margin-top: 5px;
margin-bottom: 5px;
}

.component-list-item .footer {
flex-direction: column-reverse;
}

.component-list-item .footer > select {
margin: 0px;
}

.component-list-item .footer > button {
visibility: hidden;
}

.component-list-item:hover .footer > button {
visibility: visible;
}

.component-list-item .footer > * {
display: inline-block;
margin: 5px 0px 0px 10px;
Expand Down
2 changes: 1 addition & 1 deletion arduino-ide-extension/src/browser/widgets/component-list/list-item-renderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class ListItemRenderer<T extends ArduinoComponent> {
const author = <span className="author">{item.author}</span>;
nameAndAuthor = (
<span>
{name} {nls.localize('arduino/component/by', 'by')} {author}
{name} <br /> {nls.localize('arduino/component/by', 'by')} {author}
</span>
);
} else if (item.name) {
Expand Down
8 changes: 4 additions & 4 deletions arduino-ide-extension/src/node/library-service-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,8 @@ export class LibraryServiceImpl
name: library.getName(),
installedVersion,
installable: true,
description: library.getSentence(),
summary: library.getParagraph(),
description: library.getParagraph(),
summary: library.getSentence(),
moreInfoLink: library.getWebsite(),
includes: library.getProvidesIncludesList(),
location: this.mapLocation(library.getLocation()),
Expand Down Expand Up @@ -451,9 +451,9 @@ function toLibrary(
author: lib.getAuthor(),
availableVersions,
includes: lib.getProvidesIncludesList(),
description: lib.getSentence(),
description: lib.getParagraph(),
moreInfoLink: lib.getWebsite(),
summary: lib.getParagraph(),
summary: lib.getSentence(),
category: lib.getCategory(),
types: lib.getTypesList(),
};
Expand Down