Skip to content

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Aug 29, 2024

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)

What kind of change does this PR introduce?
Updates:

  • go to version 1.23
  • extract to version 4.0.0

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information:

@cmaglie cmaglie requested a review from umbynos August 29, 2024 09:01
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.85%. Comparing base (fb06ef3) to head (9959910).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #990   +/-   ##
=======================================
  Coverage   20.85%   20.85%           
=======================================
  Files          42       42           
  Lines        2570     2570           
=======================================
  Hits          536      536           
  Misses       1949     1949           
  Partials       85       85           
Flag Coverage Δ
unit 20.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Why not upgrade directly to go 1.23? 🤔

@cmaglie
Copy link
Member Author

cmaglie commented Aug 29, 2024

LGTM. Why not upgrade directly to go 1.23? 🤔

Yes, why... I've updated to 1.23 :-)

@cmaglie cmaglie changed the title Update extract to 4.0.0 and golang to 1.22 Update extract to 4.0.0 and golang to 1.23 Aug 29, 2024
@cmaglie cmaglie self-assigned this Aug 29, 2024
@cmaglie cmaglie added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Aug 29, 2024
@cmaglie cmaglie merged commit 6f9025e into main Aug 29, 2024
48 checks passed
@cmaglie cmaglie deleted the update-extract-lib branch August 29, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants