Skip to content

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented May 16, 2024

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Code enhancement

  • What is the current behavior?

There are two ways of dowloading tools: Download and Install. The first one downloads and installs the tools from the package index only, while it is possible to provide a signed URL and a checksum to the second one to download a tool from there.

  • What is the new behavior?

Download is wrapped inside DownloadFromURL to align it to Install.

  • Does this PR introduce a breaking change?

No

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 16, 2024
@MatteoPologruto MatteoPologruto self-assigned this May 16, 2024
@MatteoPologruto MatteoPologruto requested a review from umbynos May 16, 2024 07:15
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 82.05128% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 20.10%. Comparing base (2fa738f) to head (afe92ea).
Report is 4 commits behind head on main.

Files Patch % Lines
v2/pkgs/tools.go 78.57% 6 Missing ⚠️
tools/download.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #953      +/-   ##
==========================================
- Coverage   20.64%   20.10%   -0.55%     
==========================================
  Files          42       42              
  Lines        2601     2537      -64     
==========================================
- Hits          537      510      -27     
+ Misses       1967     1943      -24     
+ Partials       97       84      -13     
Flag Coverage Δ
unit 20.10% <82.05%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatteoPologruto MatteoPologruto force-pushed the install-tools-code-dup branch 4 times, most recently from d5560fc to 4264332 Compare May 21, 2024 14:46
@MatteoPologruto MatteoPologruto force-pushed the install-tools-code-dup branch from f61f4d1 to f7f5a19 Compare May 29, 2024 14:18
@MatteoPologruto MatteoPologruto requested review from umbynos and Xayton May 29, 2024 15:45
@MatteoPologruto MatteoPologruto force-pushed the install-tools-code-dup branch from afe92ea to 18e9250 Compare June 20, 2024 15:10
@MatteoPologruto MatteoPologruto linked an issue Jun 20, 2024 that may be closed by this pull request
@MatteoPologruto MatteoPologruto merged commit 04414e2 into arduino:main Jul 2, 2024
@MatteoPologruto MatteoPologruto deleted the install-tools-code-dup branch July 2, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "keep" (cache) behavior when downloading tools
3 participants