Skip to content

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Feb 26, 2024

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

fix regression

  • What is the current behavior?

After #878 the agent is no longer able to run the firmware uploader tool since it used an hack to expand FQBN and port:

{
  "board": "arduino:renesas_uno:unor4wifi",
  "port": "/dev/cu.usbmodemDC5475C5557C2",
  "commandline": "\"{runtime.tools.arduino-fwuploader.path}/arduino-fwuploader\" firmware flash {network.password} -v --retries 5",
  "signature": "...",
  "filename": "UpdateFirmware.bin",
  "extra": {
    "auth": {
      "password": "-a /dev/cu.usbmodemDC5475C5557C2 -b \"arduino:renesas_uno:unor4wifi\""
    }
  },
  "hex": ""
}

extra.auth.password was removed in #878 because it was linked to network upload.

  • What is the new behavior?
{
  "board": "arduino:renesas_uno:unor4wifi",
  "port": "/dev/cu.usbmodemDC5475C5557C2",
  "commandline": "{runtime.tools.arduino-fwuploader.path}/arduino-fwuploader firmware flash -a {serial.port} -b {fqbn} -v --retries 5",
  "signature": "...",
  "filename": "UpdateFirmware.bin",
  "hex": ""
}

{fqbn} gets expanded with the content of board

  • Does this PR introduce a breaking change?

Nop

  • Other information:

@umbynos umbynos requested a review from cmaglie February 26, 2024 12:02
@umbynos umbynos self-assigned this Feb 26, 2024
@umbynos umbynos added the type: imperfection Perceived defect in any part of project label Feb 26, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.94%. Comparing base (16f322f) to head (6f12fb5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
+ Coverage   20.91%   20.94%   +0.02%     
==========================================
  Files          43       43              
  Lines        3160     3161       +1     
==========================================
+ Hits          661      662       +1     
  Misses       2403     2403              
  Partials       96       96              
Flag Coverage Δ
unit 20.94% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@umbynos umbynos merged commit 457b294 into main Feb 26, 2024
@umbynos umbynos deleted the fix-fwup branch February 26, 2024 15:38
@umbynos umbynos linked an issue Mar 1, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device setup is not working with 1.3.8
4 participants