Skip to content

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Nov 23, 2023

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

security fix

  • What is the current behavior?

Remove an unused endpoint

  • What is the new behavior?

The endpoint has been removed

  • Does this PR introduce a breaking change?

Technically yes, but the endpoint is unused, so it should not be a problem

  • Other information:

because it already includes built-in Output Encoding capabilities.
@umbynos umbynos added the topic: security Related to the protection of user data label Nov 23, 2023
@umbynos umbynos requested review from rhaidiz and rhpco November 23, 2023 14:19
@umbynos umbynos self-assigned this Nov 23, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e565300) 19.62% compared to head (48cf669) 19.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
+ Coverage   19.62%   19.68%   +0.06%     
==========================================
  Files          46       46              
  Lines        3685     3672      -13     
==========================================
  Hits          723      723              
+ Misses       2868     2855      -13     
  Partials       94       94              
Flag Coverage Δ
unit 19.68% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@rhpco rhpco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umbynos umbynos merged commit 9a0e582 into main Dec 11, 2023
@umbynos umbynos deleted the remove-cert-endpoint branch December 11, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: security Related to the protection of user data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants