Skip to content

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Aug 25, 2023

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Bump GOA

  • What is the current behavior?

GOA was inconsistently being used @ V1.0.1 in the go.mod file. While GOA 2.0.0-WIP was used for the generation. For maintenance reasons, we decided to bump it to v3 and generate the code again. This requires bumping also the GO version used (see #814).

  • What is the new behavior?

GOA is @ v3

  • Does this PR introduce a breaking change?

It should not

  • Other information:

Has to be rebases on main after #814 is merged ☑️

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 1.24% and project coverage change: -0.12% ⚠️

Comparison is base (d170a5e) 10.96% compared to head (b89c484) 10.85%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
- Coverage   10.96%   10.85%   -0.12%     
==========================================
  Files          55       52       -3     
  Lines        4066     4036      -30     
==========================================
- Hits          446      438       -8     
+ Misses       3565     3543      -22     
  Partials       55       55              
Flag Coverage Δ
unit 10.85% <1.24%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
gen/http/indexes/server/encode_decode.go 0.00% <0.00%> (ø)
gen/http/indexes/server/paths.go 0.00% <ø> (ø)
gen/http/indexes/server/server.go 0.00% <0.00%> (ø)
gen/http/indexes/server/types.go 0.00% <0.00%> (ø)
gen/http/tools/server/encode_decode.go 0.00% <0.00%> (ø)
gen/http/tools/server/paths.go 0.00% <ø> (ø)
gen/http/tools/server/server.go 0.00% <0.00%> (ø)
gen/http/tools/server/types.go 0.00% <0.00%> (ø)
gen/indexes/client.go 0.00% <0.00%> (ø)
gen/indexes/endpoints.go 0.00% <0.00%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@umbynos umbynos merged commit 604da4a into main Aug 28, 2023
@umbynos umbynos deleted the goa-v3 branch August 28, 2023 10:46
@umbynos umbynos mentioned this pull request Sep 5, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants