Skip to content

Check the folder content in new version of the agent on macos #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2023
Merged

Check the folder content in new version of the agent on macos #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
360a9a2
disable pushing autoupdate file on s3 for testing purposes
umbynos May 30, 2023
d6afe48
we check if the bundle is already there
umbynos Jun 9, 2023
58ee77a
fix typo
umbynos Jun 9, 2023
12f5e27
Revert "disable pushing autoupdate file on s3 for testing purposes"
umbynos Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ func oldInstallExists() bool {
if binIsOld {
return false
}
return oldAgentPath.Exist()
return oldAgentPath.Join("ArduinoCreateAgent.app").Exist()
}

// printDialog will print a GUI error dialog on macos
Expand Down
2 changes: 1 addition & 1 deletion updater/updater_darwin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func checkForUpdates(currentVersion string, updateURL string, cmdName string) (s
if currentAppPath.Ext() != ".app" {
return "", fmt.Errorf("could not find app root in %s", executablePath)
}
oldAppPath := currentAppPath.Parent().Join("ArdiunoCreateAgent.old.app")
oldAppPath := currentAppPath.Parent().Join("ArduinoCreateAgent.old.app")
if oldAppPath.Exist() {
return "", fmt.Errorf("temp app already exists: %s, cannot update", oldAppPath)
}
Expand Down