Skip to content

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 10, 2023

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?
    This PR makes all the directory handling more straightforward.
    All directories computation is now decided in config.go through the getXxxxDirectory() functions.
  • What is the current behavior?
    Directory structure and computation were spread across the code.
  • What is the new behavior?
  • Does this PR introduce a breaking change?
  • Other information:

@cmaglie cmaglie self-assigned this Feb 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

❌ Patch coverage is 0% with 124 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.28%. Comparing base (c724474) to head (1d0d5de).
⚠️ Report is 157 commits behind head on main.

Files with missing lines Patch % Lines
certificates.go 0.00% 80 Missing ⚠️
config.go 0.00% 22 Missing ⚠️
main.go 0.00% 21 Missing ⚠️
hub.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #765      +/-   ##
==========================================
- Coverage   11.40%   11.28%   -0.12%     
==========================================
  Files          51       51              
  Lines        3910     3951      +41     
==========================================
  Hits          446      446              
- Misses       3409     3450      +41     
  Partials       55       55              
Flag Coverage Δ
unit 11.28% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@umbynos umbynos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 10, 2023
@cmaglie cmaglie merged commit a3e7ecc into main Feb 10, 2023
@cmaglie cmaglie deleted the fixing_dirs branch February 10, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: code Related to content of the project itself type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants