Skip to content

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 10, 2023

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?
    This PR makes all the directory handling more straightforward.
    All directories computation is now decided in config.go through the getXxxxDirectory() functions.
  • What is the current behavior?
    Directory structure and computation were spread across the code.
  • What is the new behavior?
  • Does this PR introduce a breaking change?
  • Other information:

@cmaglie cmaglie self-assigned this Feb 10, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 11.40% // Head: 11.28% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (4dfde2f) compared to base (c724474).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #765      +/-   ##
==========================================
- Coverage   11.40%   11.28%   -0.12%     
==========================================
  Files          51       51              
  Lines        3910     3951      +41     
==========================================
  Hits          446      446              
- Misses       3409     3450      +41     
  Partials       55       55              
Flag Coverage Δ
unit 11.28% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
certificates.go 0.00% <0.00%> (ø)
config.go 0.00% <0.00%> (ø)
hub.go 0.00% <0.00%> (ø)
icon/iconlinux.go 0.00% <0.00%> (ø)
main.go 2.34% <0.00%> (+0.01%) ⬆️
systray/systray.go 0.00% <0.00%> (ø)
systray/systray_real.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@umbynos umbynos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 10, 2023
@cmaglie cmaglie merged commit a3e7ecc into main Feb 10, 2023
@cmaglie cmaglie deleted the fixing_dirs branch February 10, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants