Skip to content

Embed more files content using embed #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2023
Merged

Embed more files content using embed #762

merged 2 commits into from
Feb 9, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 9, 2023

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?
    Remove hardcoding of files in favor of embed-ing.
  • What is the current behavior?
    No changes in behavior
  • What is the new behavior?
  • Does this PR introduce a breaking change?
  • Other information:

@cmaglie cmaglie self-assigned this Feb 9, 2023
@cmaglie cmaglie requested a review from umbynos February 9, 2023 17:29
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 9, 2023
@cmaglie cmaglie merged commit bd3ba84 into main Feb 9, 2023
@cmaglie cmaglie deleted the more_embedding branch February 9, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@umbynos umbynos umbynos approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@cmaglie cmaglie

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @umbynos