Skip to content

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Nov 28, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
    - [ ] Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

CI fix

  • What is the current behavior?

The bundles generated by the CI are not valid on macOS Ventura

  • What is the new behavior?

The bundles are valid:

  • the notarization happens only for the binary and not for the bundle
  • bumped the runners
  • fixed the usage of set-output commands
  • general enhancements

  • Does this PR introduce a breaking change?

nope

  • Other information:

@umbynos umbynos added type: enhancement Proposed improvement os: macos Specific to macOS operating system topic: infrastructure Related to project infrastructure labels Nov 28, 2022
@umbynos umbynos self-assigned this Nov 28, 2022
@umbynos umbynos added this to the MacOS Ventura Support milestone Nov 28, 2022
@umbynos
Copy link
Contributor Author

umbynos commented Nov 28, 2022

@codecov-commenter
Copy link

Codecov Report

Base: 8.45% // Head: 8.45% // No change to project coverage 👍

Coverage data is based on head (7eedf9c) compared to base (b52a17a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #740   +/-   ##
=====================================
  Coverage   8.45%   8.45%           
=====================================
  Files         64      64           
  Lines       5052    5052           
=====================================
  Hits         427     427           
  Misses      4571    4571           
  Partials      54      54           
Flag Coverage Δ
unit 8.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@umbynos umbynos merged commit 31b0a9d into main Nov 29, 2022
@umbynos umbynos deleted the fix-(s)venura-CI branch November 29, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: macos Specific to macOS operating system topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants