Skip to content

fix go vet failing, followup of #668 #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2022
Merged

fix go vet failing, followup of #668 #693

merged 1 commit into from
Feb 23, 2022

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Feb 23, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

bug fix

  • What is the current behavior?

The release workflow was failing when running go vet with:

./serial.go:117:32: call of json.MarshalIndent copies lock value: github.com/arduino/arduino-create-agent.SpPortList contains sync.Mutex
./serial.go:121:32: call of json.MarshalIndent copies lock value: github.com/arduino/arduino-create-agent.SpPortList contains sync.Mutex
  • What is the new behavior?

fixed

  • Does this PR introduce a breaking change?

nop

  • Other information:

@umbynos umbynos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Feb 23, 2022
@umbynos umbynos requested a review from silvanocerza February 23, 2022 10:55
@umbynos umbynos self-assigned this Feb 23, 2022
@umbynos umbynos merged commit 75b42b9 into main Feb 23, 2022
@umbynos umbynos deleted the umbynos/fix_go_vet branch February 23, 2022 10:56
umbynos added a commit that referenced this pull request Feb 23, 2022
@umbynos
fix go vet failing, followup of #668 (#693)
80fc3e2
umbynos added a commit that referenced this pull request Feb 23, 2022
@umbynos
fix (again) go vet failing, followup of #668 and #693
b3c91fc
umbynos added a commit that referenced this pull request Feb 23, 2022
@umbynos
fix (again) go vet failing, followup of #668 and #693
dbfbb1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@silvanocerza silvanocerza silvanocerza approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@umbynos umbynos

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umbynos @silvanocerza