Skip to content

Update status bar icons #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 4, 2020
Merged

Update status bar icons #575

merged 4 commits into from
Dec 4, 2020

Conversation

sebromero
Copy link
Contributor

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?
    Updates the status bar icons on all OS
  • What is the current behavior?
    The color of the icon is different depending on the OS
  • What is the new behavior?
    The color is white (black on MacOS in light mode) on all systems.
  • Does this PR introduce a breaking change?
    No

@umbynos umbynos self-requested a review December 3, 2020 17:11
@umbynos umbynos added the type: enhancement Proposed improvement label Dec 3, 2020
umbynos
umbynos approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@sebromero
Copy link
Contributor Author

@umbynos I don't have the power to merge, feel free to do so :-)

@umbynos umbynos merged commit 96c20a9 into arduino:devel Dec 4, 2020
@umbynos umbynos mentioned this pull request Jan 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@umbynos umbynos umbynos approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sebromero sebromero

Labels
type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebromero @umbynos