Skip to content

List cores with core search #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2019
Merged

List cores with core search #405

merged 1 commit into from
Sep 20, 2019

Conversation

howjmay
Copy link
Contributor

@howjmay howjmay commented Sep 13, 2019

Mirror the same function as lib search does.
Use arduino-cli core search can list all the cores.

Fixes #354

@howjmay
List cores with core search
40b6b89 
Mirror the same function as `lib search` does.
Use `arduino-cli core search` can list all the cores.
@CLAassistant
Copy link

CLAassistant commented Sep 13, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@masci masci added this to the 0.6.0 milestone Sep 16, 2019
@masci masci self-requested a review September 20, 2019 08:00
masci
masci approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Merging...

@masci masci merged commit 8f73b78 into arduino:master Sep 20, 2019
@howjmay howjmay deleted the core_search branch September 20, 2019 10:03
@masci masci mentioned this pull request Sep 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@masci masci masci approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Make keyword argument of arduino-cli core search optional
3 participants
@howjmay @CLAassistant @masci