-
-
Notifications
You must be signed in to change notification settings - Fork 417
Try harder to not recompile sketch without modifications. #2961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cmaglie
wants to merge
7
commits into
arduino:master
Choose a base branch
from
cmaglie:do-not-recompile-sketch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18335b6
to
aa33373
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2961 +/- ##
=========================================
Coverage ? 68.31%
=========================================
Files ? 242
Lines ? 22831
Branches ? 0
=========================================
Hits ? 15596
Misses ? 6029
Partials ? 1206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was
linked to
issues
Aug 17, 2025
aa33373
to
aa41179
Compare
aa41179
to
1ca362c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: build-process
Related to the sketch build process
topic: code
Related to content of the project itself
type: enhancement
Proposed improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Improves the checks made to the sketch to avoid useless recompilation and preprocessing.
What is the current behavior?
The sketch source code, before being compiled, undergoes a two-phase processing:
Previously, these two operations were always performed, touching the final
sketch.cpp
. This resulted insketch.cpp
being recompiled every time. Moreover, the library discovery cache could not be exploited because of thesketch.cpp
timestamp change.What is the new behavior?
The merged sketch file is saved in a separate
sketch.cpp.merged
file, and it is compared to the newly generated content. If they match, the already preprocessedsketch.cpp
andsketch.cpp.merged
are left untouched.This is enough for the current build system to recognize that the file is already up-to-date and skip both compilation and library discovery, which greatly improves compile times.
Does this PR introduce a breaking change, and is titled accordingly?
Unless I'm missing some convoluted case, it shouldn't.
Other information