Skip to content

Tidy go mods #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2019
Merged

Tidy go mods #284

merged 1 commit into from
Jul 17, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Jul 17, 2019

Some users are reporting problems while go get -u-ing the project, this won't help in all cases but it's still good to consolidate the mod status.

@masci masci mentioned this pull request Jul 17, 2019
Closed
rsora
rsora approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvarisco gvarisco self-requested a review July 17, 2019 08:31
gvarisco
gvarisco approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@gvarisco gvarisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masci masci merged commit aa21da5 into master Jul 17, 2019
@masci masci deleted the massi/tidy branch July 17, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@gvarisco gvarisco gvarisco approved these changes

@rsora rsora rsora approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masci @gvarisco @rsora