Skip to content

Monitor gRPC call now sends a 'success' message to notify open port #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Monitor gRPC call now sends a 'success' message to notify open port #1742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions commands/daemon/daemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,9 @@ func (s *ArduinoCoreServerImpl) Monitor(stream rpc.ArduinoCoreService_MonitorSer
return err
}

// Send a message with Success set to true to notify the caller of the port being now active
_ = stream.Send(&rpc.MonitorResponse{Success: true})

go func() {
// close port on gRPC call EOF or errors
defer portProxy.Close()
Expand Down
91 changes: 51 additions & 40 deletions rpc/cc/arduino/cli/commands/v1/monitor.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions rpc/cc/arduino/cli/commands/v1/monitor.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ message MonitorResponse {
// report the default settings) or after a new port_configuration is sent
// (to report the new settings applied)
repeated MonitorPortSetting applied_settings = 3;
// A message with this field set to true is sent as soon as the port is
// succesfully opened
bool success = 4;
}

message MonitorPortSetting {
Expand Down