Pin Ace* libraries at last compatible version in CI workflow #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to incompatibilities introduced during the initial ArduinoCore-API incorporation, the author of the AceTime and AceCommon libraries has added an #error directive that is triggered when the libraries are compiled by any version of arduino;samd that uses ArduinoCore-API: - https://github.com/bxparks/AceTime/blob/v1.6/src/AceTime.h#L25-L26 - https://github.com/bxparks/AceCommon/blob/v1.4.3/src/AceCommon.h#L44-L45 Ironically, compilation of the AceTime examples was added specifically to avoid any future breakage of compatibility with that library. Now the shoe is on the other foot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to incompatibilities introduced during the initial ArduinoCore-API incorporation (#587), the author of the AceTime and AceCommon libraries has added an #error directive that is triggered when the libraries are compiled by any version of
arduino:samdthat uses ArduinoCore-API :Ironically, compilation of the AceTime example sketch was added with the goal of avoiding any future breakage of compatibility with that library (#588).
Pinning the libraries to the version before the intentional breakage of compatibility by the libraries gets us back to the sketch compilations failing due to the original unintentional breakage by
arduino:samd.Closes #606 (CC: @stonehippo)