Skip to content

WiFiS3 Udp, Client: avoid RX_BUFFER_DIM redefinition #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024
Merged

WiFiS3 Udp, Client: avoid RX_BUFFER_DIM redefinition #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions libraries/WiFiS3/src/WiFiClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@
#include "FifoBuffer.h"
#include <memory>

#define RX_BUFFER_DIM 1024

class WiFiClient : public Client {

public:
Expand Down Expand Up @@ -74,6 +72,7 @@ class WiFiClient : public Client {
int _sock;
int _connectionTimeout = 0;
void getSocket();
static constexpr uint32_t RX_BUFFER_DIM = 1024;
std::shared_ptr<FifoBuffer<uint8_t,RX_BUFFER_DIM>> rx_buffer;
int _read();
void read_if_needed(size_t s);
Expand Down
3 changes: 1 addition & 2 deletions libraries/WiFiS3/src/WiFiUdp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,10 @@
#include "Modem.h"
#include "FifoBuffer.h"

#define RX_BUFFER_DIM 1461

class WiFiUDP : public UDP {
private:
int _sock;
static constexpr uint32_t RX_BUFFER_DIM = 1461;
FifoBuffer<uint8_t,RX_BUFFER_DIM> rx_buffer;

protected:
Expand Down