Rename CurieBle to CurieBLE #91
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepmistry
force-pushed
the
ble-case-rename
branch
from
c662af8 to
a30c0d0
Compare
|
I've rebased this and removed the previous merge conflict. |
|
Isn't this going to break any existing users' sketches that import |
|
@soundanalogous yes, it is a breaking change. It was discussed internally at Arduino, leaving acronyms all uppercase is more Arduino "style". |
|
@SidLeung @bigdinotech Please review |
|
@calvinatintel please merge |
|
Cherry-picked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #90, it's more Arduino style to leave acronyms uppercase. So, these changes rename
CurieBletoCurieBLE.Once again we'll have to sync the tutorial content prior to releasing.