Skip to content

Bugfix: Small buffer size causes buffer overrun when invoking String::Ctor with large float/double value. #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 10, 2020
Merged

Bugfix: Small buffer size causes buffer overrun when invoking String::Ctor with large float/double value. #131

merged 3 commits into from
Dec 10, 2020

Conversation

aentinger
Copy link
Contributor

@aentinger aentinger commented Dec 9, 2020 •
edited
Loading

This fixes #128.

@aentinger aentinger self-assigned this Dec 9, 2020
@aentinger
Calling String::String(float ...) with +/- FLT_MAX or String::String(…
f3cfa2f 
…double ...) with +/- DBL_MAX results in a stack smashing.
@aentinger aentinger requested a review from facchinm December 9, 2020 09:38
@aentinger aentinger merged commit 78f3f41 into master Dec 10, 2020
@aentinger aentinger deleted the fix-buf-size-float branch December 10, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm Awaiting requested review from facchinm

Assignees

@aentinger aentinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase buffer size for converting floats + doubles to String's
1 participant
@aentinger