Skip to content

Conversation

sebromero
Copy link
Collaborator

  • Added labels to components
  • Better comments to make clear that the program needs to wait for the servo to finish moving

@sebromero sebromero requested a review from aentinger July 6, 2022 08:29
@aentinger
Copy link
Contributor

It looks good to me, however I was wondering if you should not maybe directly use the push/pop APIs due to #71 .

@sebromero
Copy link
Collaborator Author

@aentinger Not sure I can follow. The graphics that I changed illustrates the "classic" approach. The other two graphics are conceptual without showing any API. Where would you add the API calls?

@aentinger
Copy link
Contributor

I thought the illustration was representing multi-threading, as it shows two separate loop functions as well as the comments indicate two separate tasks ("Task 1: Read Potentiometer", "Task 2: Adjust Servo Position"). So I thought it could be like

shared_angle.push(angle);

and

myservo.write(shared_angle.pop());

@sebromero
Copy link
Collaborator Author

@aentinger Ah, no, it was supposed to illustrate the sheer concept of a "task". The ... dots were supposed to indicate that it's the same loop function. Okay, good feedback, I'll revise :-)

@sebromero
Copy link
Collaborator Author

@aentinger I updated it. Clearer now?

@aentinger
Copy link
Contributor

@aentinger I updated it. Clearer now?

Crystal 🔮 👍

@aentinger aentinger merged commit 35e9e33 into main Jul 6, 2022
@aentinger aentinger deleted the improved-graphic branch July 6, 2022 11:10
@per1234 per1234 added topic: documentation Related to documentation for the project type: enhancement Proposed improvement labels Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants