Skip to content

Conversation

fpistm
Copy link
Contributor

@fpistm fpistm commented Mar 21, 2025

src/utility/L2CAPSignaling.cpp: In member function 'virtual void L2CAPSignalingClass::handleSecurityData(uint16_t, uint8_t, uint8_t*)':
src/utility/L2CAPSignaling.cpp:315:5: warning: missing initializer for member 'L2CAPSignalingClass::handleSecurityData(uint16_t, uint8_t, uint8_t*)::GenerateDHKeyCommand::y' [-Wmissing-field-initializers]
  315 |     };
      |     ^
src/utility/L2CAPSignaling.cpp:116:81: warning: unused parameter 'dlen' [-Wunused-parameter]
  116 | void L2CAPSignalingClass::handleSecurityData(uint16_t connectionHandle, uint8_t dlen, uint8_t data[])
      |                                                                         ~~~~~~~~^~~~
src/utility/L2CAPSignaling.cpp: In member function 'virtual void L2CAPSignalingClass::smCalculateLTKandConfirm(uint16_t, uint8_t*)':
src/utility/L2CAPSignaling.cpp:418:19: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
  418 |     for(int i=0; i<sizeof(Eb); i++){
      |                  ~^~~~~~~~~~~
src/utility/HCI.cpp: In member function 'virtual void HCIClass::poll(long unsigned int)':
src/utility/HCI.cpp:142:20: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
  142 |     if (_recvIndex >= sizeof(_recvBuffer)) {
      |         ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
src/utility/HCI.cpp: In member function 'virtual void HCIClass::saveNewAddress(uint8_t, uint8_t*, uint8_t*, uint8_t*)':
src/utility/HCI.cpp:464:39: warning: unused parameter 'addressType' [-Wunused-parameter]
  464 | void HCIClass::saveNewAddress(uint8_t addressType, uint8_t* address, uint8_t* peerIrk, uint8_t* localIrk){
      |                               ~~~~~~~~^~~~~~~~~~~
src/utility/HCI.cpp:464:97: warning: unused parameter 'localIrk' [-Wunused-parameter]
  464 | void HCIClass::saveNewAddress(uint8_t addressType, uint8_t* address, uint8_t* peerIrk, uint8_t* localIrk){
      |                                                                                        ~~~~~~~~~^~~~~~~~
src/utility/HCI.cpp: In member function 'virtual int HCIClass::leReadPeerResolvableAddress(uint8_t, uint8_t*, uint8_t*)':
src/utility/HCI.cpp:506:107: warning: unused parameter 'peerResolvableAddress' [-Wunused-parameter]
  506 | int HCIClass::leReadPeerResolvableAddress(uint8_t peerAddressType, uint8_t* peerIdentityAddress, uint8_t* peerResolvableAddress){
      |                                                                                                  ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
src/utility/HCI.cpp: In member function 'virtual int HCIClass::readStoredLK(uint8_t*, uint8_t)':
src/utility/HCI.cpp:550:19: warning: missing initializer for member 'HCIClass::readStoredLK(uint8_t*, uint8_t)::Request::read_a' [-Wmissing-field-initializers]
  550 |   } request = {0,0};
      |                   ^
src/utility/HCI.cpp: In member function 'virtual void HCIClass::handleEventPkt(uint8_t, uint8_t*)':
src/utility/HCI.cpp:1275:30: warning: missing initializer for member 'HCIClass::handleEventPkt(uint8_t, uint8_t*)::F4Params::V' [-Wmissing-field-initializers]
 1275 |           } f4Params = {0,0,Z};
      |                              ^
src/utility/HCI.cpp:1275:30: warning: missing initializer for member 'HCIClass::handleEventPkt(uint8_t, uint8_t*)::F4Params::Z' [-Wmissing-field-initializers]
src/utility/HCI.cpp:1295:25: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
 1295 |           for(int i=0; i<sizeof(pairingConfirm.cb);i++){
      |                        ~^~~~~~~~~~~~~~~~~~~~~~~~~~
src/utility/HCI.cpp: In member function 'virtual int HCIClass::leEncrypt(uint8_t*, uint8_t*, uint8_t*, uint8_t*)':
src/utility/HCI.cpp:1383:28: warning: missing initializer for member 'HCIClass::leEncrypt(uint8_t*, uint8_t*, uint8_t*, uint8_t*)::LeEncryptCommand::plaintext' [-Wmissing-field-initializers]
 1383 |   } leEncryptCommand = {0,0};
      |                            ^
src/utility/HCI.cpp:1378:68: warning: unused parameter 'status' [-Wunused-parameter]
 1378 | int HCIClass::leEncrypt(uint8_t* key, uint8_t* plaintext, uint8_t* status, uint8_t* ciphertext){
      |                                                           ~~~~~~~~~^~~~~~
src/utility/btct.cpp: In member function 'int BluetoothCryptoToolbox::f5(uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*)':
src/utility/btct.cpp:74:33: warning: missing initializer for member 'BluetoothCryptoToolbox::f5(uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*)::CmacInput::N2' [-Wmissing-field-initializers]
   74 |     } cmacInput = {0,0,0,0,0,0,0};
      |                                 ^
src/utility/btct.cpp:74:33: warning: missing initializer for member 'BluetoothCryptoToolbox::f5(uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*)::CmacInput::A1' [-Wmissing-field-initializers]
src/utility/btct.cpp:74:33: warning: missing initializer for member 'BluetoothCryptoToolbox::f5(uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*)::CmacInput::A2' [-Wmissing-field-initializers]
src/utility/btct.cpp:74:33: warning: missing initializer for member 'BluetoothCryptoToolbox::f5(uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*)::CmacInput::length' [-Wmissing-field-initializers]
src/utility/btct.cpp: In member function 'int BluetoothCryptoToolbox::f6(uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*)':
src/utility/btct.cpp:100:29: warning: missing initializer for member 'BluetoothCryptoToolbox::f6(uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*)::F6Input::N2' [-Wmissing-field-initializers]
  100 |     } f6Input = {0,0,0,0,0,0};
      |                             ^
src/utility/btct.cpp:100:29: warning: missing initializer for member 'BluetoothCryptoToolbox::f6(uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*)::F6Input::R' [-Wmissing-field-initializers]
src/utility/btct.cpp:100:29: warning: missing initializer for member 'BluetoothCryptoToolbox::f6(uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*)::F6Input::IOCap' [-Wmissing-field-initializers]
src/utility/btct.cpp:100:29: warning: missing initializer for member 'BluetoothCryptoToolbox::f6(uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*)::F6Input::A1' [-Wmissing-field-initializers]
src/utility/btct.cpp:100:29: warning: missing initializer for member 'BluetoothCryptoToolbox::f6(uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*)::F6Input::A2' [-Wmissing-field-initializers]
src/utility/btct.cpp: In member function 'int BluetoothCryptoToolbox::g2(uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*)':
src/utility/btct.cpp:148:24: warning: missing initializer for member 'BluetoothCryptoToolbox::g2(uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*)::CmacInput::V' [-Wmissing-field-initializers]
  148 |     } cmacInput= {0,0,0};
      |                        ^
src/utility/btct.cpp:148:24: warning: missing initializer for member 'BluetoothCryptoToolbox::g2(uint8_t*, uint8_t*, uint8_t*, uint8_t*, uint8_t*)::CmacInput::Y' [-Wmissing-field-initializers]

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Mar 21, 2025
Copy link

Memory usage change @ bf62cd5

Board flash % RAM for global variables %
arduino:mbed_nano:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 💚 -4 - -4 -0.0 - -0.0 0 - 0 0.0 - 0.0
arduino:megaavr:uno2018:mode=on 🔺 +4 - +4 +0.01 - +0.01 0 - 0 0.0 - 0.0
arduino:renesas_uno:unor4wifi 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 💚 -8 - 0 -0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 💚 -8 - 0 -0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Central/LedControl
flash
% examples/Central/LedControl
RAM for global variables
% examples/Central/PeripheralExplorer
flash
% examples/Central/PeripheralExplorer
RAM for global variables
% examples/Central/Scan
flash
% examples/Central/Scan
RAM for global variables
% examples/Central/ScanCallback
flash
% examples/Central/ScanCallback
RAM for global variables
% examples/Central/SensorTagButton
flash
% examples/Central/SensorTagButton
RAM for global variables
% examples/Peripheral/Advertising/EnhancedAdvertising
flash
% examples/Peripheral/Advertising/EnhancedAdvertising
RAM for global variables
% examples/Peripheral/Advertising/RawDataAdvertising
flash
% examples/Peripheral/Advertising/RawDataAdvertising
RAM for global variables
% examples/Peripheral/BatteryMonitor
flash
% examples/Peripheral/BatteryMonitor
RAM for global variables
% examples/Peripheral/ButtonLED
flash
% examples/Peripheral/ButtonLED
RAM for global variables
% examples/Peripheral/CallbackLED
flash
% examples/Peripheral/CallbackLED
RAM for global variables
% examples/Peripheral/EncryptedBatteryMonitor
flash
% examples/Peripheral/EncryptedBatteryMonitor
RAM for global variables
% examples/Peripheral/LED
flash
% examples/Peripheral/LED
RAM for global variables
%
arduino:mbed_nano:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect -4 -0.0 0 0.0 -4 -0.0 0 0.0 -4 -0.0 0 0.0 -4 -0.0 0 0.0 -4 -0.0 0 0.0 -4 -0.0 0 0.0 -4 -0.0 0 0.0 -4 -0.0 0 0.0 -4 -0.0 0 0.0 -4 -0.0 0 0.0 -4 -0.0 0 0.0 -4 -0.0 0 0.0
arduino:megaavr:uno2018:mode=on 4 0.01 0 0.0 4 0.01 0 0.0 4 0.01 0 0.0 4 0.01 0 0.0 4 0.01 0 0.0 4 0.01 0 0.0 4 0.01 0 0.0 4 0.01 0 0.0 4 0.01 0 0.0 4 0.01 0 0.0 4 0.01 0 0.0 4 0.01 0 0.0
arduino:renesas_uno:unor4wifi 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 0 0.0 0 0.0 0 0.0 0 0.0 -8 -0.0 0 0.0 -8 -0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -8 -0.0 0 0.0 -8 -0.0 0 0.0 -8 -0.0 0 0.0 0 0.0 0 0.0 -8 -0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot 0 0.0 0 0.0 0 0.0 0 0.0 -8 -0.0 0 0.0 -8 -0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -8 -0.0 0 0.0 -8 -0.0 0 0.0 -8 -0.0 0 0.0 0 0.0 0 0.0 -8 -0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/Central/LedControl<br>flash,%,examples/Central/LedControl<br>RAM for global variables,%,examples/Central/PeripheralExplorer<br>flash,%,examples/Central/PeripheralExplorer<br>RAM for global variables,%,examples/Central/Scan<br>flash,%,examples/Central/Scan<br>RAM for global variables,%,examples/Central/ScanCallback<br>flash,%,examples/Central/ScanCallback<br>RAM for global variables,%,examples/Central/SensorTagButton<br>flash,%,examples/Central/SensorTagButton<br>RAM for global variables,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>flash,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>RAM for global variables,%,examples/Peripheral/Advertising/RawDataAdvertising<br>flash,%,examples/Peripheral/Advertising/RawDataAdvertising<br>RAM for global variables,%,examples/Peripheral/BatteryMonitor<br>flash,%,examples/Peripheral/BatteryMonitor<br>RAM for global variables,%,examples/Peripheral/ButtonLED<br>flash,%,examples/Peripheral/ButtonLED<br>RAM for global variables,%,examples/Peripheral/CallbackLED<br>flash,%,examples/Peripheral/CallbackLED<br>RAM for global variables,%,examples/Peripheral/EncryptedBatteryMonitor<br>flash,%,examples/Peripheral/EncryptedBatteryMonitor<br>RAM for global variables,%,examples/Peripheral/LED<br>flash,%,examples/Peripheral/LED<br>RAM for global variables,%
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0
arduino:megaavr:uno2018:mode=on,4,0.01,0,0.0,4,0.01,0,0.0,4,0.01,0,0.0,4,0.01,0,0.0,4,0.01,0,0.0,4,0.01,0,0.0,4,0.01,0,0.0,4,0.01,0,0.0,4,0.01,0,0.0,4,0.01,0,0.0,4,0.01,0,0.0,4,0.01,0,0.0
arduino:renesas_uno:unor4wifi,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,-8,-0.0,0,0.0,-8,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-8,-0.0,0,0.0,-8,-0.0,0,0.0,-8,-0.0,0,0.0,0,0.0,0,0.0,-8,-0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,-8,-0.0,0,0.0,-8,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-8,-0.0,0,0.0,-8,-0.0,0,0.0,-8,-0.0,0,0.0,0,0.0,0,0.0,-8,-0.0,0,0.0,0,0.0,0,0.0

@facchinm facchinm merged commit 7a039d7 into arduino-libraries:master Apr 8, 2025
11 checks passed
@fpistm fpistm deleted the fix_warning branch April 8, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants