Multiview Support #446
Open
Multiview Support #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add codechecker workflow - enable `-pedantic` - fix a lot of warnings - only report error from `gbm_surface_create_with_modifiers` if `gbm_surface_create` fails too
|
does this PR support multi display? I would like to help on testing, I have DSI and HDMI displays. is this run on single flutter engine or multiple engines? |
|
@ardera can you maybe add a video or a linked ticket, in case we want to test this so we know what to actually test? |
drmdev: (mostly) non-stateful part. Basically a better wrapper around a drm fd. Fully mt-safe. Also properly separate kms_req from drmdev. kms_req now mostly accesses public drmdev API, instead of having access to hidden drmdev state. drm_resources: the DRM state / resources. Is stateful, but does not update itself. To keep it in sync with kernel state, one needs to listen to kernel events with drm_monitor and call drm_resources_update. drm_resources is not mt-safe and only supposed to be used on a single thread. Also add a bunch of QoL stuff to drm_resources.
To be able to specify more surface usage hints, i.e. `GBM_BO_USE_SCANOUT` and `GBM_BO_USE_RENDERING`.
Always do non-blocking atomic commits. To resolve issues with flutter trying to present frames too soon, while another frame was already sent to the kernel (i.e. comitted via KMS atomic commit), we either have to discard subsequent, too-early frames or queue them. In this case, we basically keep a 1-frame deep queue (or 2-frames, if you count the in-kernel waiting-for-scanout frame), with the 1 queued frame being displaced whenever a newer frame is available. (Similar to vulkans MAILBOX swapchain presentation mode)
Call the release callback for the commit that is no longer visible on screen before calling the scanout callback. The scanout callback might already start a new frame, and the release callback releases some resources that could be useful for building the new frame, so this helps avoid resource exhaustion.
libdrm's drmIsKMS was added in libdrm 2.4.105:
https://gitlab.freedesktop.org/mesa/libdrm/-/commit/523b3658aa8efa746417e916c987de23740ce313
Debian bullseye is still on 2.4.104, so it's unfortunately not present
there.
- add multidisplay plugin stub
- make compositor multiview capable
- use klib (khash) to implement the
view id -> window mapping
- use evloop as platform and raster thread
event loop (mt-safe wrapper around sd-event)
- add own mutex type & fns with thread safety annotations
- generally refactor flutter-pi.c and drmdev
- fix function mixup in sentry plugin
- kms: add drm device monitor
for sd_event_source_disable_unref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.