Skip to content

Add IElementFinder implementation #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 1, 2019
Merged

Add IElementFinder implementation #27

merged 5 commits into from
Aug 1, 2019

Conversation

@mialeska
Copy link
Contributor

@mialeska mialeska commented Jul 31, 2019

Resolves #23

@mialeska mialeska added this to the Basic implementation milestone Jul 31, 2019
@mialeska mialeska requested review from knysh and paveliam July 31, 2019 15:51
@mialeska mialeska self-assigned this Jul 31, 2019
paveliam
paveliam reviewed Jul 31, 2019
View reviewed changes
mialeska and others added 2 commits August 1, 2019 10:54
@mialeska
add return documentation into IElementFinder
ffe97bd
@knysh @mialeska
Feature/implement conditional wait (#26)
52ec7ad 
* #2 added some condtional waits

* changed default(TimeSpan) to nullable

* default(TimeSpan) to nullable

* #2 moved all unit tests to specific folder

* #2 removed redundant ;

* #2 removed static logger

* #2 resolve comments

* #2 updated logging in ConditionalWait

* #2 updated logging
@mialeska mialeska merged commit 37157a5 into master Aug 1, 2019
@paveliam paveliam deleted the Feature/23-add-ielementfinder branch August 3, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knysh knysh knysh approved these changes

@paveliam paveliam paveliam approved these changes

Assignees

@mialeska mialeska

Labels

None yet

Projects

None yet

Milestone

Basic implementation

Development

Successfully merging this pull request may close these issues.

Add IElementFinder and its implementation

4 participants

@mialeska @knysh @paveliam