Skip to content

Fixes #114 - Replace @preconcurrency import Foundation with scoped import #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 9, 2023
Merged

Fixes #114 - Replace @preconcurrency import Foundation with scoped import #36

merged 6 commits into from
Aug 9, 2023

Conversation

PARAIPAN9
Copy link
Contributor

Motivation

  • As described in the issue, I want to import the specific modules when preconcurrency is being used

Modifications

  • import the specific modules

Result

  • Instead of importing an entire module, now it is imported just the specific parts that are necessary

Test Plan

  • Make sure that the project builds
  • Run and passed al the tests

@czechboy0
Copy link
Contributor

@swift-server-bot add to allowlist

czechboy0
czechboy0 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @PARAIPAN9! Looks good, let's see if CI runs without any warnings as well.

czechboy0
czechboy0 requested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some CI issues.

czechboy0
czechboy0 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you @PARAIPAN9!

@czechboy0 czechboy0 merged commit cd8104a into apple:main Aug 9, 2023
@czechboy0 czechboy0 added the 🔨 semver/patch No public API change. label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@czechboy0 czechboy0 czechboy0 approved these changes

Assignees

No one assigned

Labels

🔨 semver/patch No public API change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PARAIPAN9 @czechboy0