Skip to content

Conversation

@heckj
Copy link
Contributor

@heckj heckj commented Apr 14, 2025

Motivation:

When viewing the documentation, deprecated methods clutter up available options, sometimes below, making those options hard to find for a developer working out how to add or create a TLSConfiguration.

Modifications:

Adds a DocC extension file (markdown format) the provides curation (organization of the symbols) to order by task and ideally usefulness, with deprecated methods pushed downward.

Result:

The documentation at
https://swiftpackageindex.com/apple/swift-nio-ssl/main/documentation/niossl/tlsconfiguration (and future releases) will include this organization and be easier to read through for developers.

@Lukasa Lukasa added the semver/none No version bump required. label Apr 14, 2025
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@Lukasa Lukasa enabled auto-merge (squash) April 14, 2025 15:28
@heckj
Copy link
Contributor Author

heckj commented Apr 14, 2025

Ah... docs-check in soundness (which failed) is running with a Swift 6.0 image, and I used 6.1, which has some slightly different patterns of resolving overloaded methods. I'll apply updates to the DocC content that work with DocC in Swift 6.0 to resolve.

Motivation:

When viewing the documentation, deprecated methods clutter up available options, sometimes below,
making those options hard to find for a developer working out how to add or create a TLSConfiguration.

Modifications:

Adds a DocC extension file (markdown format) the provides curation (organization of the symbols)
to order by task and ideally usefulness, with deprecated methods pushed downward.

Result:

The documentation at
https://swiftpackageindex.com/apple/swift-nio-ssl/main/documentation/niossl/tlsconfiguration
(and future releases) will include this organization and be easier to read through for developers.
auto-merge was automatically disabled April 14, 2025 20:29

Head branch was pushed to by a user without write access

@heckj heckj force-pushed the TLSconfiguration-curation branch from 777917f to acac00a Compare April 14, 2025 20:29
@heckj
Copy link
Contributor Author

heckj commented Apr 14, 2025

I ended up stripping out the curation for the overloaded deprecated initializers, as I couldn't land what the relevant hashes were to get Swift 6.0 to reliably agree they were acceptable variants. This still leaves them at the bottom of the document, albeit uncurated.

The curation I applied originally is relevant in Swift 6.1, but won't pass checks with the current GH action review, which uses Swift 6.0's version of DocC and its older disambiguation process.

@Lukasa
Copy link
Contributor

Lukasa commented Apr 15, 2025

Are you happy to proceed with this in its current form @heckj?

@heckj
Copy link
Contributor Author

heckj commented Apr 15, 2025

Yes, thank you @Lukasa - mostly wanted to get the soundness checks passing

@Lukasa Lukasa merged commit 66cfda0 into apple:main Apr 16, 2025
42 checks passed
@heckj heckj deleted the TLSconfiguration-curation branch April 16, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants