Skip to content

Cleanup missing internal Sendable annotation and missing preconcurrency import #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025
Merged

Cleanup missing internal Sendable annotation and missing preconcurrency import #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9947cf
Backing storage needs a sendable annotation
Lukasa Feb 4, 2025
6073d3b
Security framework doesn't have Sendability annotations
Lukasa Feb 4, 2025
11fabd9
Merge branch 'main' into cb-simple-sendable-cleanups
glbrntt Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/NIOSSL/SecurityFrameworkCertificateVerification.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import NIOCore
#if canImport(Darwin)
import Dispatch
import Foundation
import Security
@preconcurrency import Security

extension SSLConnection {
func performSecurityFrameworkValidation(
Expand Down
3 changes: 3 additions & 0 deletions Sources/NIOSSL/SubjectAlternativeName.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ public struct _SubjectAlternativeNames {
// _SubjectAlternativeNames is immutable and therefore Sendable
extension _SubjectAlternativeNames: @unchecked Sendable {}

// _SubjectAlternativeNames.Storage is immutable and therefore Sendable
extension _SubjectAlternativeNames.Storage: @unchecked Sendable {}

extension _SubjectAlternativeNames: RandomAccessCollection {

@inlinable public subscript(position: Int) -> _SubjectAlternativeName {
Expand Down