Enable MemberImportVisibility check on all targets #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnro
force-pushed
the
enable_MemberImportVisibility_check
branch
from
e795944 to
e5e447f
Compare
rnro
changed the title
rnro
force-pushed
the
enable_MemberImportVisibility_check
branch
2 times, most recently
from
a8eedcb to
720591b
Compare
rnro
added
🔨 semver/patch
rnro
force-pushed
the
enable_MemberImportVisibility_check
branch
from
8d62050 to
1185bd6
Compare
glbrntt
reviewed
Dec 17, 2024
Comment on lines
17
to
19
| #if os(Linux) || os(FreeBSD) || os(Android) | ||
| import CNIOLinux | ||
| #endif |
There was a problem hiding this comment.
You should be able to unconditionally import this -- it if-defs itself so that it's empty on other platforms.
There was a problem hiding this comment.
Thanks, I forgot I did that here
unconditionally import CNIOLinux
glbrntt
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable MemberImportVisibility check on all targets. Use a standard string header and footer to bracket the new block for ease of updating in the future with scripts.