Skip to content

Conversation

guoye-zhang
Copy link
Contributor

Resolves #76

@guoye-zhang
Copy link
Contributor Author

Are there ways to re-export these symbols so we don't need to introduce API breakages?

2 breaking changes detected in HTTPTypesFoundation:
  💔 API breakage: var HTTPRequest.url has been removed
  💔 API breakage: constructor HTTPRequest.init(method:url:headerFields:) has been removed

Maybe @_exported import or @_disfavoredOverload?

@Lukasa
Copy link
Contributor

Lukasa commented Dec 16, 2024

@_exported import is totally workable.

@guoye-zhang
Copy link
Contributor Author

@_exported import doesn't seem to address the API breakage check. Maybe the check itself is too strict?

@Lukasa
Copy link
Contributor

Lukasa commented Dec 19, 2024

API breakage is usually strict, and I think this is one way in which it is.

@FranzBusch FranzBusch added the 🔨 semver/patch No public API change. label Jan 2, 2025
@weissi
Copy link
Member

weissi commented Oct 15, 2025

@guoye-zhang hey, any updates here

@guoye-zhang
Copy link
Contributor Author

This requires an admin to take action since it fails the ABI breakage check

@FranzBusch
Copy link
Member

Can you update the branch to resolve the conflicts. I can help with getting it merged.

@guoye-zhang
Copy link
Contributor Author

Rebased. I think this is a "semver/minor" change since it technically adds an API?

@weissi
Copy link
Member

weissi commented Oct 17, 2025

This is the output

2 breaking changes detected in HTTPTypesFoundation:
  💔 API breakage: var HTTPRequest.url has been removed
  💔 API breakage: constructor HTTPRequest.init(method:url:headerFields:) has been removed
Error: Process completed with exit code 1.

but I think that's bogus because of the @_exported import which brings those APIs back. @FranzBusch how do we override that check?

@Lukasa Lukasa merged commit 3acdb1c into apple:main Oct 17, 2025
55 of 56 checks passed
@weissi
Copy link
Member

weissi commented Oct 17, 2025

Amazing, thanks @guoye-zhang & @Lukasa , I'd appreciate a release with this change so we can update and remove our copies of this code base. Thank you

@guoye-zhang guoye-zhang deleted the move-url branch October 18, 2025 00:54
@guoye-zhang guoye-zhang added 🆕 semver/minor Adds new public API. and removed 🔨 semver/patch No public API change. labels Oct 18, 2025
@guoye-zhang
Copy link
Contributor Author

I just tagged 1.5.0 with this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🆕 semver/minor Adds new public API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

import HTTPTypesFoundation pulls in FoundationNetworking

4 participants