-
Notifications
You must be signed in to change notification settings - Fork 64
Move HTTPRequest.url to the main library #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are there ways to re-export these symbols so we don't need to introduce API breakages?
Maybe |
|
|
API breakage is usually strict, and I think this is one way in which it is. |
@guoye-zhang hey, any updates here |
This requires an admin to take action since it fails the ABI breakage check |
Can you update the branch to resolve the conflicts. I can help with getting it merged. |
Rebased. I think this is a "semver/minor" change since it technically adds an API? |
This is the output
but I think that's bogus because of the |
Amazing, thanks @guoye-zhang & @Lukasa , I'd appreciate a release with this change so we can update and remove our copies of this code base. Thank you |
I just tagged 1.5.0 with this change |
Resolves #76