tests: Improve diagnostics and robustness of test shell scripts #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euanh
added
area/testing
euanh
changed the title
euanh
changed the title
euanh
force-pushed
the
test-script-robustness
branch
from
e93e408 to
bb98b64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tests scripts are used by GitHub Actions and when running tests locally. They should have consistent structures, clean up after themselves and print useful messages so that failures can be diagnosed.
Modifications
run-integration-tests.shResult
Test failures will be easier to diagnose
Test Plan
Existing tests continue to pass.