tests: Build the layering test images on scratch to avoid pulling swift:slim #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euanh
added
semver/none
euanh
changed the title
euanh
force-pushed
the
layering-test-from-scratch
branch
2 times, most recently
from
3d3b786 to
3c282c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The layering tests sometimes fail with 400 errors from the registry. This error could be caused by pulling the underlying base image from Docker Hub, although the logs do not give enough information to be certain.
We don't need to run the container image in order to check that the payload file is being layered correctly. This would avoid the need to pull
swift:slim, reducing the risk of external systems causing test failures.Modifications
Build the test image on scratch.
Instead of running the container and using
catto check the contents of/payload, create a container from the image and copy/payloadout, without starting the container.Result
The layering tests should be less susceptible to failures caused by external systems.
Test Plan
All tests continue to pass.