Move to grpc-swift V2 #379
Draft
+6,256
−3,176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No real notable API changes. The largest change code wise is in Vminitd. The connection loop is setup immediately in the new API by calling runConnections() on the client, and this blocks until either the task it's running on is cancelled or beginGracefulShutdown is called. Because of this, either we'd have to modify our API to have VirtualMachineAgent implementations call some run() method, or we just put runConnections in an internal task on Vminitd. I went for the latter approach as it's simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
No API changes which is nice. The largest change code wise is in Vminitd. The connection loop is setup immediately in the new API by calling
runConnections()on the client, and this blocks until either the task it's running on is cancelled orbeginGracefulShutdownis called. Because of this, either we'd have to modify our API to have VirtualMachineAgent implementations call somerun()method, or we just putrunConnections()in an internal task on Vminitd. I went for the latter approach as it's simpler.