[build-command]: Add --pull option for fetching latest image #844
+21
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saehejkang
force-pushed
the
build-command-add-pull-option
branch
from
54381da to
e370b26
Compare
saehejkang
changed the title
saehejkang
force-pushed
the
build-command-add-pull-option
branch
from
e370b26 to
f782063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Closes #733.
Even with the
--pullflag added, It made no sense to always pull the base image, if it already exists locally. Checking for it locally first and then pulling made more sense. Furthermore, if the base image already exists locally and you turn off wifi/internet - the builder no longer gets stuck on the "fetching" step.Testing