[image-save-load]: support for stdin/stdout #734
+116
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saehejkang
force-pushed
the
image-save-load-support-stdin-stdout
branch
2 times, most recently
from
3029055 to
b0de0e0
Compare
jglogan
requested changes
Oct 9, 2025
saehejkang
changed the title
saehejkang
commented
Oct 17, 2025
1 task
jglogan
requested changes
Nov 1, 2025
7 tasks
7 tasks
saehejkang
force-pushed
the
image-save-load-support-stdin-stdout
branch
from
09dae23 to
023aa94
Compare
jglogan
added a commit
that referenced
this pull request
Nov 15, 2025
When working on test cases for #827 and #734 the following issues occurred 1. There was no support to pass in `Data` for `stdin` (input pipe added + new argument for the data) 2. Pipes were getting blocked during the `try process.run()` and `process.waitUntilExit()` (order of operations were fixed) 3. We need the binary data for directly piping the `stdout` data to `stdin`, and converting the data to a `string`, returns `""` (added a new value to the tuple) I opened a new PR here for this as I did not want to bloat the other PRs with so many updates. At first I thought of creating a new function named `runStdinStdout`, but that seemed redundant as it pretty much was going to do the same thing as `run`. ## Testing - [x] Tested locally - [x] Added/updated tests - [ ] Added/updated docs --------- Co-authored-by: J Logan <[email protected]>
Contributor
|
@saehejkang Just merged the underlying test change, could you resolve conflicts on this? I'll have a look after and then try building it and doing a little local testing. Thanks! |
saehejkang
force-pushed
the
image-save-load-support-stdin-stdout
branch
2 times, most recently
from
f2b7f54 to
b230226
Compare
saehejkang
force-pushed
the
image-save-load-support-stdin-stdout
branch
from
b2f6d4d to
e06ef37
Compare
Contributor
Author
jglogan
reviewed
Nov 15, 2025
Contributor
jglogan
left a comment
jglogan
left a comment
There was a problem hiding this comment.
Looks good, wanted to see what your thought about making the conditionals for the stdio cases a little more straightforward. And thanks for adding the tests, that capability will likely be handy elsewhere.
|
|
||
| progress.set(description: "Loading tar archive") | ||
| let loaded = try await ClientImage.load(from: input) | ||
| let loaded = try await ClientImage.load(from: input ?? tempFile.path()) |
Contributor
There was a problem hiding this comment.
nit: What do you think about restructuring load like to only run the code that's needed for each case? The only bit of code that repeats is the ClientImage.load line, and we would be removing a conditional from that.
var loaded: ClientImage
if input == nil {
// create tmpfile, defer delete, copy stdin to file
loaded = try await ClientImage.load(from: tempFile.path())
} else {
// ensure input exists
loaded = loaded = try await ClientImage.load(from: input)
}|
|
||
| try await ClientImage.save(references: references, out: output ?? tempFile.path(), platform: p) | ||
|
|
||
| // Write to stdout |
Contributor
There was a problem hiding this comment.
Same for this one, we could put an else on this that just saves the image to output, and move the above code into the output == nil case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Closes #559
Testing
Example Commands with Outputs
Save the docker image to the
test.tarfileUse the
test.tarfile to load the imagecontainer image load < test.tar Loaded images: docker.io/library/nginx:latest