Skip to content

#552 FIX #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 20, 2017
Merged

#552 FIX #556

merged 10 commits into from
Jan 20, 2017

Conversation

@TikhomirovSergey
Copy link
Contributor

@TikhomirovSergey TikhomirovSergey commented Jan 17, 2017

Change list

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

There is #552 FIX.
Generating of RemoteWebElement is normal now. It should happen when current driver is swithed to WebView/browser. Otherwise it generates native Android/iOS etc elements according to platformName parameter of the current session

@TikhomirovSergey
#552 fix:
d75aa26 
- HasSessionDetails declares two additional methods now:  String getPlatformName() and String  getAutomationName()
- these methods are re-implemented by AppiumDriver.
- AppiumFieldDecorator refactoring
@TikhomirovSergey
#552 fix: the work is going on.
57a1760 
- HasSessionDetails declares the additional method isBrowser()
- improving of element generating engine
@TikhomirovSergey
#552 fix: iOS - test
b945ba6 
- IOSElementGenerationTest was designed
- AndroidElementGeneratingTest was re-designed
@TikhomirovSergey
improvement of WebView tests
ca06e97
@TikhomirovSergey TikhomirovSergey self-assigned this Jan 17, 2017
SrinivasanTarget
SrinivasanTarget reviewed Jan 18, 2017
View reviewed changes
Copy link
Member

@SrinivasanTarget SrinivasanTarget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@TikhomirovSergey
The bug of the isBrowser() method was fixed.
e4a2a85
@TikhomirovSergey
Check style issue and bug fixes
3047a97
@TikhomirovSergey
Merge remote-tracking branch 'origin/master'
9444993 
# Conflicts:
#	src/main/java/io/appium/java_client/AppiumDriver.java
#	src/test/java/io/appium/java_client/appium/element/generation/ios/IOSElementGenerationTest.java
@TikhomirovSergey
IOSElementGenerationTest improvement
d940158
@TikhomirovSergey TikhomirovSergey merged commit 02b5b64 into appium:master Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

Assignees

@TikhomirovSergey TikhomirovSergey

Labels

bug enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TikhomirovSergey @SrinivasanTarget